refactor(shared): remove unused functions from settings.ts #135

Merged

jonas.hanisch merged 1 commit from refactor/128-cleanup-settings-ts into main

2026-01-24 12:07:27 +00:00

jack commented

2026-01-24 09:45:46 +00:00

Owner

Summary

Removed 6 unused functions/methods from settings.ts
Reduced file by 52 lines

Removed Functions

Function	Type	Reason
`getDefault()`	SettingsManager method	Never called
`reload()`	SettingsManager method	Never called
`resetSettings()`	Standalone	Testing helper, never used
`createSettingsManager()`	Standalone	Factory function, never used
`generateAuthToken()`	Standalone	Only used by ensureWorkerAuthToken
`ensureWorkerAuthToken()`	Standalone	Never called

Kept Functions (actively used)

getSettings() - singleton accessor
loadSettings() - convenience function
saveSettings() - persistence function

Note

These functions can be re-added if needed in the future. The auth token functionality might be useful for secure worker communication, but it's not currently implemented.

Test plan

TypeScript compilation passes
Settings loading/saving still works

Closes #128

🤖 Generated with Claude Code

## Summary - Removed 6 unused functions/methods from `settings.ts` - Reduced file by 52 lines ## Removed Functions | Function | Type | Reason | |----------|------|--------| | `getDefault()` | SettingsManager method | Never called | | `reload()` | SettingsManager method | Never called | | `resetSettings()` | Standalone | Testing helper, never used | | `createSettingsManager()` | Standalone | Factory function, never used | | `generateAuthToken()` | Standalone | Only used by ensureWorkerAuthToken | | `ensureWorkerAuthToken()` | Standalone | Never called | ## Kept Functions (actively used) - `getSettings()` - singleton accessor - `loadSettings()` - convenience function - `saveSettings()` - persistence function ## Note These functions can be re-added if needed in the future. The auth token functionality might be useful for secure worker communication, but it's not currently implemented. ## Test plan - [x] TypeScript compilation passes - [ ] Settings loading/saving still works Closes #128 🤖 Generated with [Claude Code](https://claude.com/claude-code)

jack added 1 commit

2026-01-24 09:45:46 +00:00

refactor(shared): remove unused functions from settings.ts

CI / check (pull_request) Successful in 0s

Details

CI / build (pull_request) Successful in 42s

Details

CI / validate-plugin (pull_request) Successful in 35s

Details

cc7edef21f

Removed 6 unused functions/methods:

SettingsManager methods:
- getDefault() - never called
- reload() - never called

Standalone functions:
- resetSettings() - testing helper, never used
- createSettingsManager() - factory function, never used
- generateAuthToken() - only used by ensureWorkerAuthToken
- ensureWorkerAuthToken() - never called

These can be re-added when needed. Keeping the codebase clean.

Fixes #128

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>