fix(ui): stop event propagation on observation tab buttons #126

Merged
jonas.hanisch merged 1 commit from fix/123-tab-event-propagation into main 2026-01-24 11:58:45 +00:00
Owner

Summary

  • Fixes tab buttons collapsing the observation card when clicked
  • Added e.stopPropagation() to both Narrative and Details tab buttons

Problem

In the Memories view, when clicking on a tab (Narrative/Details) to switch views, the click event bubbled up to the card's onClick handler and collapsed the expanded card.

Solution

Added e.stopPropagation() to the tab button onClick handlers to prevent the event from bubbling up.

Test plan

  • Open Memories view
  • Expand an observation card
  • Click on "Details" tab - card should stay expanded
  • Click on "Narrative" tab - card should stay expanded
  • Click outside the tabs on the card header - card should collapse (unchanged behavior)

Closes #123

🤖 Generated with Claude Code

## Summary - Fixes tab buttons collapsing the observation card when clicked - Added `e.stopPropagation()` to both Narrative and Details tab buttons ## Problem In the Memories view, when clicking on a tab (Narrative/Details) to switch views, the click event bubbled up to the card's onClick handler and collapsed the expanded card. ## Solution Added `e.stopPropagation()` to the tab button onClick handlers to prevent the event from bubbling up. ## Test plan - [ ] Open Memories view - [ ] Expand an observation card - [ ] Click on "Details" tab - card should stay expanded - [ ] Click on "Narrative" tab - card should stay expanded - [ ] Click outside the tabs on the card header - card should collapse (unchanged behavior) Closes #123 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix: MCP server respects remote backend configuration
All checks were successful
CI / check (pull_request) Successful in 0s
CI / build (pull_request) Successful in 41s
CI / validate-plugin (pull_request) Successful in 36s
280ca611f3
The MCP server was ignoring REMOTE_MODE, REMOTE_URL, and REMOTE_TOKEN
settings, always connecting to localhost. This fix:

- Loads settings via loadSettings() from @claude-mem/shared
- Uses REMOTE_URL when REMOTE_MODE is enabled
- Adds Authorization header with REMOTE_TOKEN for all API calls
- Falls back to localhost with env var overrides in local mode

Fixes #122

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
fix(ui): stop event propagation on observation tab buttons
All checks were successful
CI / check (pull_request) Successful in 1s
CI / build (pull_request) Successful in 42s
CI / validate-plugin (pull_request) Successful in 35s
d1d58ff2dc
Clicking the Narrative/Details tabs in an expanded observation card
caused the card to collapse because the click event bubbled up to
the card's onClick handler.

Added e.stopPropagation() to both tab buttons to prevent this.

Fixes #123

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
jonas.hanisch force-pushed fix/123-tab-event-propagation from d1d58ff2dc
All checks were successful
CI / check (pull_request) Successful in 1s
CI / build (pull_request) Successful in 42s
CI / validate-plugin (pull_request) Successful in 35s
to 6be57c6c05
All checks were successful
CI / check (pull_request) Successful in 1s
CI / build (pull_request) Successful in 1m20s
CI / validate-plugin (pull_request) Successful in 1m8s
2026-01-24 10:39:40 +00:00
Compare
jonas.hanisch force-pushed fix/123-tab-event-propagation from 6be57c6c05
All checks were successful
CI / check (pull_request) Successful in 1s
CI / build (pull_request) Successful in 1m20s
CI / validate-plugin (pull_request) Successful in 1m8s
to 40f8856961
Some checks failed
CI / build (pull_request) Has been cancelled
2026-01-24 11:43:35 +00:00
Compare
jonas.hanisch force-pushed fix/123-tab-event-propagation from 40f8856961
Some checks failed
CI / build (pull_request) Has been cancelled
to b0512fd9e8
All checks were successful
CI / build (pull_request) Successful in 41s
2026-01-24 11:55:55 +00:00
Compare
jonas.hanisch force-pushed fix/123-tab-event-propagation from b0512fd9e8
All checks were successful
CI / build (pull_request) Successful in 41s
to 9d9af7ef1a
All checks were successful
CI / build (pull_request) Successful in 38s
2026-01-24 11:57:57 +00:00
Compare
jonas.hanisch deleted branch fix/123-tab-event-propagation 2026-01-24 11:58:45 +00:00
Sign in to join this conversation.
No description provided.