fix(ui): stop event propagation on observation tab buttons #187

Merged

jack merged 6 commits from fix/126-stop-propagation-tabs into main

2026-01-24 13:06:24 +00:00

jack commented

2026-01-24 10:38:43 +00:00

Owner

Summary

Fixes tab buttons collapsing the observation card when clicked
Added e.stopPropagation() to both Narrative and Details tab buttons

Problem

When clicking on a tab (Narrative/Details) to switch views, the click event bubbled up to the card's onClick handler and collapsed the expanded card.

Solution

Added e.stopPropagation() to the tab button onClick handlers.

Closes #126

Test plan

Open Memories view
Expand an observation card
Click on "Details" tab - card should stay expanded
Click on "Narrative" tab - card should stay expanded

## Summary - Fixes tab buttons collapsing the observation card when clicked - Added `e.stopPropagation()` to both Narrative and Details tab buttons ## Problem When clicking on a tab (Narrative/Details) to switch views, the click event bubbled up to the card's onClick handler and collapsed the expanded card. ## Solution Added `e.stopPropagation()` to the tab button onClick handlers. Closes #126 ## Test plan - [ ] Open Memories view - [ ] Expand an observation card - [ ] Click on "Details" tab - card should stay expanded - [ ] Click on "Narrative" tab - card should stay expanded

jack added 1 commit

2026-01-24 10:38:44 +00:00

fix(ui): stop event propagation on observation tab buttons

CI / check (pull_request) Successful in 0s

Details

CI / build (pull_request) Successful in 48s

Details

CI / validate-plugin (pull_request) Successful in 1m3s

Details

cfd60efdf2

Fixes tab buttons collapsing the observation card when clicked.
Added e.stopPropagation() to both Narrative and Details tab buttons.

Closes #126

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>