fix: queue worker termination when not yet connected to hub #121

Merged

jonas.hanisch merged 1 commit from fix/120-worker-termination-busy-check into main

2026-01-24 11:26:52 +00:00

jack commented

2026-01-24 09:27:22 +00:00

Owner

Problem

When terminating a worker that wasn't yet connected to the WorkerHub (connectedWorkerId = undefined), the busy-check was completely skipped and the worker was immediately killed - even if it was actively processing a task.

// Before: Bug - this check was skipped when hubWorkerId was undefined
if (hubWorkerId && this.deps.workerHub.isWorkerBusy(hubWorkerId)) {
  // queue termination
}
// Worker was killed immediately if no hubWorkerId!

Solution

Added safety check: If a worker has status: 'running' but no hub connection yet, queue the termination instead of killing immediately.

// After: Safe - queue termination if worker is running but not connected
if (!hubWorkerId && spawnedWorker.status === 'running') {
  this.deps.workerProcessManager.queueTermination(id);
  return { queued: true, reason: 'Worker not yet connected to hub' };
}

Test Plan

Start a worker
Immediately try to terminate before it connects to hub
Verify termination is queued, not immediate
Verify worker terminates gracefully after connecting

Fixes #120

🤖 Generated with Claude Code

## Problem When terminating a worker that wasn't yet connected to the WorkerHub (`connectedWorkerId = undefined`), the busy-check was completely skipped and the worker was immediately killed - even if it was actively processing a task. ```typescript // Before: Bug - this check was skipped when hubWorkerId was undefined if (hubWorkerId && this.deps.workerHub.isWorkerBusy(hubWorkerId)) { // queue termination } // Worker was killed immediately if no hubWorkerId! ``` ## Solution Added safety check: If a worker has `status: 'running'` but no hub connection yet, queue the termination instead of killing immediately. ```typescript // After: Safe - queue termination if worker is running but not connected if (!hubWorkerId && spawnedWorker.status === 'running') { this.deps.workerProcessManager.queueTermination(id); return { queued: true, reason: 'Worker not yet connected to hub' }; } ``` ## Test Plan - [ ] Start a worker - [ ] Immediately try to terminate before it connects to hub - [ ] Verify termination is queued, not immediate - [ ] Verify worker terminates gracefully after connecting Fixes #120 🤖 Generated with [Claude Code](https://claude.ai/code)

jack added 1 commit

2026-01-24 09:27:22 +00:00

fix: queue worker termination when not yet connected to hub

CI / check (pull_request) Successful in 0s

Details

CI / build (pull_request) Successful in 41s

Details

CI / validate-plugin (pull_request) Successful in 34s

Details

fa2a0c7159

Previously, when terminating a worker that wasn't yet connected to the
WorkerHub (connectedWorkerId = undefined), the busy-check was skipped
and the worker was immediately killed - even if it was processing a task.

Now, if a worker has status 'running' but no hub connection yet, the
termination is queued for safety instead of killing immediately.

Fixes #120

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>