feat(shared): add secret detection and redaction #213

jack · 2026-01-24T17:20:35Z

jack commented

2026-01-24 17:20:35 +00:00

Summary

Implements Issue #191 - Automatic detection and redaction of secrets in prompts and observations.

Features

Secret Detection Patterns

API Keys: OpenAI (sk-), Anthropic (sk-ant-), GitHub PAT (ghp_), GitLab PAT (glpat-)
AWS: Access Keys (AKIA), Secret Access Keys
Passwords: Generic password/secret/token patterns
Connection Strings: MongoDB, PostgreSQL, MySQL, Redis URIs
Private Keys: RSA, EC, DSA, OpenSSH private key headers
Tokens: JWT, Bearer tokens, Basic Auth

Configuration

{
  "SECRET_DETECTION_ENABLED": true,
  "SECRET_DETECTION_MODE": "redact"  // "redact" | "skip" | "warn"
}

Modes

redact: Replace secrets with [REDACTED:type] (default)
skip: Don't store observations/prompts containing secrets
warn: Log warning but store unchanged

Changes

packages/shared/src/secret-detector.ts (NEW)
- detectSecrets() - Find secrets in text
- redactSecrets() - Replace secrets with placeholders
- processSecrets() - Process based on config
- calculateEntropy() - Shannon entropy for high-entropy detection
packages/shared/src/settings.ts
- Added SECRET_DETECTION_ENABLED setting
- Added SECRET_DETECTION_MODE setting
packages/hooks/src/handlers/post-tool-use.ts
- Redact secrets in tool input/output before sending to backend
packages/hooks/src/handlers/user-prompt-submit.ts
- Redact secrets in user prompts before storing

Test plan

Submit a prompt containing sk-test1234567890123456789012345678901234
Verify it's redacted to [REDACTED:openai_key] in database
Use a tool that outputs a password pattern
Verify tool output is redacted
Set SECRET_DETECTION_MODE: "skip" and verify observations are skipped
Set SECRET_DETECTION_MODE: "warn" and verify secrets are logged but stored

Closes #191

🤖 Generated with Claude Code

## Summary Implements Issue #191 - Automatic detection and redaction of secrets in prompts and observations. ## Features ### Secret Detection Patterns - **API Keys**: OpenAI (`sk-`), Anthropic (`sk-ant-`), GitHub PAT (`ghp_`), GitLab PAT (`glpat-`) - **AWS**: Access Keys (`AKIA`), Secret Access Keys - **Passwords**: Generic password/secret/token patterns - **Connection Strings**: MongoDB, PostgreSQL, MySQL, Redis URIs - **Private Keys**: RSA, EC, DSA, OpenSSH private key headers - **Tokens**: JWT, Bearer tokens, Basic Auth ### Configuration ```json { "SECRET_DETECTION_ENABLED": true, "SECRET_DETECTION_MODE": "redact" // "redact" | "skip" | "warn" } ``` ### Modes - **redact**: Replace secrets with `[REDACTED:type]` (default) - **skip**: Don't store observations/prompts containing secrets - **warn**: Log warning but store unchanged ## Changes - **packages/shared/src/secret-detector.ts** (NEW) - `detectSecrets()` - Find secrets in text - `redactSecrets()` - Replace secrets with placeholders - `processSecrets()` - Process based on config - `calculateEntropy()` - Shannon entropy for high-entropy detection - **packages/shared/src/settings.ts** - Added `SECRET_DETECTION_ENABLED` setting - Added `SECRET_DETECTION_MODE` setting - **packages/hooks/src/handlers/post-tool-use.ts** - Redact secrets in tool input/output before sending to backend - **packages/hooks/src/handlers/user-prompt-submit.ts** - Redact secrets in user prompts before storing ## Test plan - [ ] Submit a prompt containing `sk-test1234567890123456789012345678901234` - [ ] Verify it's redacted to `[REDACTED:openai_key]` in database - [ ] Use a tool that outputs a password pattern - [ ] Verify tool output is redacted - [ ] Set `SECRET_DETECTION_MODE: "skip"` and verify observations are skipped - [ ] Set `SECRET_DETECTION_MODE: "warn"` and verify secrets are logged but stored Closes #191 🤖 Generated with [Claude Code](https://claude.com/claude-code)

jack added 1 commit

2026-01-24 17:20:35 +00:00

feat(shared): add secret detection and redaction

CI / build (pull_request) Successful in 52s

Details

a05f787930

Implements Issue #191 - Automatic detection and redaction of secrets.

- Add secret-detector.ts utility with:
  - Pattern-based detection for API keys, passwords, connection strings
  - Support for OpenAI, Anthropic, AWS, GitHub, GitLab tokens
  - JWT, Bearer token, and Basic Auth detection
  - Configurable modes: redact, skip, or warn
  - Shannon entropy calculation for high-entropy strings

- Add settings:
  - SECRET_DETECTION_ENABLED (default: true)
  - SECRET_DETECTION_MODE (default: 'redact')

- Integrate into hooks:
  - post-tool-use.ts: Redact secrets in tool input/output
  - user-prompt-submit.ts: Redact secrets in user prompts

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

jack added the

labels

2026-01-24 17:20:38 +00:00

jonas.hanisch force-pushed feat/191-secret-detection from a05f787930

CI / build (pull_request) Successful in 52s

Details

to ba17f4c33c

CI / build (pull_request) Successful in 39s